install.sh update (fixes) #242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorx00
reviewed
Nov 5, 2025
Comment on lines
+175
to
+177
| if [ "$major" -gt 0 ] || | ||
| [ "$major" -eq 0 ] && [ "$minor" -gt 7 ] || | ||
| [ "$major" -eq 0 ] && [ "$minor" -eq 7 ] && [ "$patch" -ge 0 ]; then |
There was a problem hiding this comment.
Is it possible to rely on the sorting command for version comparing?
min_version="0.7.0"
[ "$(printf '%s\n' "$version" "$min_version" | sort -V | head -1)" = "$min_version" ] && echo OK || echo NOKTested with ash from BusyBox v1.36.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#236
Описание изменений
Изменить порядок операций, чтобы минимизировать ошибки устаноки
Что изменено
Детальное описание изменений:
проверки версии OpenWrt, доступности DNS - как сейчас
opkg update - при ошибке останавливаем скрипт "Проблема доступности репозиториев, повторите позже или проверьте distfeeds.conf"
скачивание .ipk файлов podkop в /tmp, если не удалось за 3 попытки - останавливаем скрипт с ошибкой "Проблема загрузки релиза с GitHub"
проверка установленной версии sing-box, если меньше минимальной - обновляем. при ошибке - останавливаем дальнейшее обновление
если переход с версии ниже 0.7.0 - предупреждаем и удаляем конфиг
обновление из скачанных на 3 шаге файлов
Первый пул крахом немного (больше GPT не использую, извиняюсь)
Теперь все должно работать адекватно.